This repository has been archived by the owner on Jun 21, 2024. It is now read-only.
Streaming Serializer [WIP][Concept] #90
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable drone on feature branches
Remove wildcard on feature branch CI
IljaN
commented
Jul 29, 2019
| */ | ||
| public function deserialize($data, $type) { | ||
| return $this->serializer->deserialize($data, $type, 'json', []); | ||
| private function readLines($stream, $lineBufSize = 256) { |
There was a problem hiding this comment.
This method might not be needed as streams should be lazy by default
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modifies serializer to encode from streams. The basic idea is to use generators to lazily stream all objects trough the export or import chain thus reducing memory usage.
Related Issue
#89
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: